Skip to content

Windows: add retry logic and explicit failure for Unity license activation - #765

Open
kijz wants to merge 5 commits into
game-ci:mainfrom
kijz:main
Open

Windows: add retry logic and explicit failure for Unity license activation#765
kijz wants to merge 5 commits into
game-ci:mainfrom
kijz:main

Conversation

@kijz

@kijz kijz commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

Changes

  • Add retry logic around Windows Unity license activation (dist/platforms/windows/entrypoint.ps1) to mitigate transient activation failures (up to 3 attempts, with a short delay and warning on retries).
  • Improve failure signaling on Windows by exiting with an explicit non-zero status (exit 1) after failed activation attempts, ensuring the workflow reliably reports failure.

Related Issues

  • N/A (no linked issue in this PR).
  • We are using self hosted custom Windows Runner which would sometimes get stuck, these changes mitigate random error codes resulting in a stuck build

Related PRs

  • N/A

Successful Workflow Run Link

PRs don't have access to secrets so you will need to provide a link to a successful run of the workflows from your own
repo.

  • N/A

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Docs (If new inputs or outputs have been added or changes to behavior that should be documented. Please make a PR
    in the documentation repo)
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@coderabbitai

coderabbitai Bot commented Dec 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • dist/platforms/windows/entrypoint.ps1 is excluded by !**/dist/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 83445b1c-0259-4c2c-a00e-674b1908f09f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Dec 15, 2025

Copy link
Copy Markdown

Cat Gif

@codecov

codecov Bot commented Dec 15, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.37%. Comparing base (0c82a58) to head (f442913).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   38.37%   38.37%           
=======================================
  Files          78       78           
  Lines        3171     3171           
  Branches      665      665           
=======================================
  Hits         1217     1217           
  Misses       1809     1809           
  Partials      145      145
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@frostebite frostebite mentioned this pull request Mar 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kijz